generated from amazon-archives/__template_Custom
-
Notifications
You must be signed in to change notification settings - Fork 34
go: use runtime FIPS instead of compile-time boringcrypto #315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcressey
reviewed
Jan 7, 2026
6498996 to
53e2670
Compare
ginglis13
reviewed
Jan 14, 2026
bcressey
reviewed
Jan 14, 2026
patches/go-1.25/0002-Always-restrict-boringcrypto-crypto-tls-to-FIPS.patch
Show resolved
Hide resolved
Signed-off-by: Jingwei Wang <[email protected]>
Signed-off-by: Jingwei Wang <[email protected]>
Contributor
Author
|
commit to father clean up the prepare stage and macro. |
bcressey
approved these changes
Jan 15, 2026
Signed-off-by: Jingwei Wang <[email protected]>
Signed-off-by: Jingwei Wang <[email protected]>
Signed-off-by: Jingwei Wang <[email protected]>
Signed-off-by: Jingwei Wang <[email protected]>
Signed-off-by: Jingwei Wang <[email protected]>
Remove GOLIBC=musl handling from go and gofips wrappers since separate musl Go trees are no longer needed without AWS-LC syso files. Signed-off-by: Jingwei Wang <[email protected]>
Remove AWS-LC syso file COPY statements and simplify musl Go tree creation since syso files are no longer used. Signed-off-by: Jingwei Wang <[email protected]>
Contributor
Author
|
pushed to fix typo |
ginglis13
approved these changes
Jan 16, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: #318
Description of changes:
This is the minimal change for switching
boringcryptoto runtimeGODEBUG=fips140=only. Will remove the gofips build in a separate PR and release.FIPS compliance is now controlled at runtime via GODEBUG=fips140=only environment variable rather than compile-time GOEXPERIMENT=boringcrypto.
Testing done:
Testing with PR1, below showing the
gofipspoint to regular go build.original:
Build with this change:
Testing with PR1, and showing the fips work with go runtime variale
detail in: https://gist.github.com/sky1122/2fe6925332e7d9443eb149d5f45df116
result show the pull from non-fips cypher registry fail
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.